Skip to content

Change counter code - #243

Merged
insolor merged 1 commit into
mainfrom
replace-yandex-metrika-counter
Nov 2, 2026
Merged

insolor merged 1 commit into
mainfrom
replace-yandex-metrika-counter

Conversation

@insolor

@insolor insolor commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Updated the site’s GoatCounter analytics property from insolor to async-tkinter-loop. This is a configuration change; no other changes to the site’s features or behavior are included in this update.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The GoatCounter analytics property in mkdocs.yml changed from insolor to async-tkinter-loop.

Changes: Analytics configuration

Layer / File(s) Summary
Update GoatCounter property
mkdocs.yml
The configured GoatCounter property changed to async-tkinter-loop.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to efb32

Documentation analytics will use the new GoatCounter property. No merge-blocking risk is established.

Security architecture risk: Low · up to efb32

The change redirects documentation analytics to another GoatCounter property without expanding deployment permissions. No introduced vulnerability was established, but ownership of the new analytics property has not been verified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The direct security-relevant scope is documentation visitors whose pages use this analytics template. The destination property changes, but its account owner, access controls, and actual event contents are not established by the inspected source.

Trust Boundaries and Controls

  • observed — The repository-configured property is interpolated into an HTTPS URL with a fixed goatcounter.com suffix. The new value is a fixed project identifier, not visitor-supplied input. The external analytics integration already exists at the base revision.

Hardening Proposals

  • proposed — Confirm that async-tkinter-loop is controlled by the intended analytics account and authorized to receive documentation telemetry before publishing the changed configuration.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@insolor
insolor merged commit 16cdc0b into main Nov 2, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant