Repository navigation
Enable Windows CUDA CI - #262
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 194 194
Lines 17349 17349
Branches 943 943
=======================================
Hits 16816 16816
Misses 533 533
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Run build and ccache steps under bash so failures aren't masked by pwsh - Gate the x86-64-v3 check to Linux - Drop /Zi from Windows Debug flags so ccache can cache compiles - Remove the deprecated gha-setup-ninja action Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Run the simulator and GPU tests on Linux only, keep Jimver for the Windows build, and restore the Linux Release job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a Windows leg to the CUDA workflow and fixes CI issues that the new leg exposed in
cuda.yml,continuous.yml, and the nvcc warning flags.setup-pantheonsim(from CI: run the GPU unit tests on a simulated GPU #265) installs CUDA 12.8 with a simulated T4 and runs the GPU tests. On Windows,Jimver/cuda-toolkit@v0.2.35installs CUDA 13.2, and the job only builds, since PantheonSim only supports Linux.msvc-dev-cmd), withCMAKE_CUDA_COMPILERpassed explicitly becausecheck_language(CUDA)doesn't reliably find nvcc on the runner.Impact:
CI fixes
bash. Under the Windows default,pwsh, a failingcmake --buildfollowed byccache --show-statsreported success./Zi, which ccache can't cache, the same way Linux drops-g.seanmiddleditch/gha-setup-ninja@masterfrom both workflows. The action is deprecated, and Ninja ships on all GitHub-hosted runners.Build change
-isysteminclude, and-Werror all-warningsturns both into errors.ipc_toolkit_warnings.cmakenow passes-diag-suppress=128,2417for MSVC hosts only. The Linux build still treats both as errors, so our own code is still checked.-Werror all-warningsalso turns MSVC's own host-pass warnings into errors, so#pragma GCCinlbvh.hppfailed on C4068. The MSVC/wdlist is now shared and forwarded to nvcc's host pass with-Xcompiler, matching the C++ build.Type of change
How Has This Been Tested?
Linux CUDA (Debug)passed on CUDA 13.2 before the merge with CI: run the GPU unit tests on a simulated GPU #265.Windows CUDA (Debug)previously failed on the fmt warnings, then on C4068. Both fixes are inf7e4c0779, and its run is pending.Test Configuration:
ubuntu-latest,windows-latest(GitHub-hosted)Checklist