Skip to content

Keep Teams' client id when a sent message is echoed - #37

Merged
itz4blitz merged 3 commits into
mainfrom
fix/teams-echo-client-id
Oct 18, 2026
Merged

itz4blitz merged 3 commits into
mainfrom
fix/teams-echo-client-id

Conversation

@itz4blitz

Copy link
Copy Markdown
Owner

Summary

  • macOS CI on main failed twice in sending_editing_reacting_deleting_and_reading_go_to_teams: Teams had already been asked to post, but the message never looked accepted.
  • The HTTP answer marks the row sent with the shell's client id. About 100ms later the echo arrives without clientmessageid copied onto the message, and the store replaces the row, dropping that id. A slow poll misses the window and waits out the 20s timeout.
  • The echo now keeps clientmessageid (text or number) on our own messages, which is what the store uses to replace the pending row.

Test plan

  • cargo test -p chatd --lib a_copy_of_our_message_keeps_the_client_id_teams_echoes
  • cargo test -p chatd --test teams sending_editing_reacting_deleting_and_reading_go_to_teams
  • CI on macOS, Linux, and Windows

Made with Cursor

itz4blitz and others added 3 commits October 17, 2026 21:14
…y still matches the pending row.

Co-authored-by: Cursor <cursoragent@cursor.com>
…stop warning that Node 20 is deprecated.

Co-authored-by: Cursor <cursoragent@cursor.com>
… file out before the close is noticed.

Co-authored-by: Cursor <cursoragent@cursor.com>
@itz4blitz
itz4blitz merged commit 44ad327 into main Oct 18, 2026
6 checks passed
@itz4blitz
itz4blitz deleted the fix/teams-echo-client-id branch October 18, 2026 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant