Repository navigation
Keep Teams' client id when a sent message is echoed - #37
Merged
Merged
Conversation
…y still matches the pending row. Co-authored-by: Cursor <cursoragent@cursor.com>
…stop warning that Node 20 is deprecated. Co-authored-by: Cursor <cursoragent@cursor.com>
… file out before the close is noticed. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainfailed twice insending_editing_reacting_deleting_and_reading_go_to_teams: Teams had already been asked to post, but the message never looked accepted.clientmessageidcopied onto the message, and the store replaces the row, dropping that id. A slow poll misses the window and waits out the 20s timeout.clientmessageid(text or number) on our own messages, which is what the store uses to replace the pending row.Test plan
cargo test -p chatd --lib a_copy_of_our_message_keeps_the_client_id_teams_echoescargo test -p chatd --test teams sending_editing_reacting_deleting_and_reading_go_to_teamsMade with Cursor