Repository navigation
Conversation
The window hardcoded the macOS keychain, Finder, and Always Allow. Those sentences now follow the computer the build runs on: the system keyring on Linux, Credential Manager on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Linux build of 0.2.5 shows Mac copy: "Your sign-in is kept in the macOS keychain on this Mac.", "Show in Finder", and "Choose Always Allow". Those sentences were compiled in for every system.
hostnow names the computer this build runs on.PRETTY_NAMEfrom os-release instead of asw_versline that never appears.xdg-open, the same as opening a file already does.Test plan
cargo test -p tinyclient host::on Linux, macOS, and Windows (CI runs this on all three)