Skip to content

Remove flattenTypes from readAnalysisOptionsFromJaspFile - #26

Merged
boutinb merged 2 commits into
jasp-stats:masterfrom
boutinb:removeFlattenTypes
Nov 16, 2026
Merged

boutinb merged 2 commits into
jasp-stats:masterfrom
boutinb:removeFlattenTypes

Conversation

@boutinb

@boutinb boutinb commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Change

Removes the flattenTypes argument of readAnalysisOptionsFromJaspFile() and the internal flattenedAnalysisOptionsFromJaspFile() (added in #20).

flattenTypes only existed for jaspTools' analysisOptions(<file>.jasp), which split the saved {value, types} options into <name> and <name>.types. jaspTools (jasp-stats/jaspTools#101) now gives the saved options as they are: the QML form of the analysis reads that shape. It also runs an analysis of a .jasp file through jaspBase::runWrappedAnalysis() with the options as saved. Nothing else calls it.

includeTypeOptions = FALSE still drops the <name>.types that the option encoder writes next to a nested option, for the runtime options.

Version 1.4.4. This follows #24 (1.4.2) and #25 (1.4.3), so the version line may conflict trivially.

Merge order

jaspTools master still calls readAnalysisOptionsFromJaspFile(flattenTypes = TRUE). Merge this after jasp-stats/jaspTools#101.

The SyntaxInterface export syntaxBridgeFlattenedAnalysisOptionsFromJaspFileStatus in jasp-desktop is left alone: released versions of jaspSyntax still call it.

Tests

On a build of #24 + #25 + this: 490 expectations, 2 failures, both in test-dataset-info.R. These also fail on master with the released native library. jaspTools' suite (#101) passes against it: 1039 expectations, 0 failures.

🤖 Generated with Claude Code

flattenTypes (jasp-stats#20) was added for jaspTools' analysisOptions(<file>.jasp), which split
the saved {value, types} options into <name> and <name>.types. jaspTools now gives
the saved options as they are: the QML form of the analysis reads that shape, and
it runs an analysis of a .jasp file through jaspBase::runWrappedAnalysis. Nothing
else used it, so the argument and the internal flattenedAnalysisOptionsFromJaspFile
go. The nested <name>.types that the option encoder writes are still dropped with
includeTypeOptions = FALSE, for the runtime options.

Version 1.4.4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@boutinb
boutinb merged commit dac1a44 into jasp-stats:master Nov 16, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant