Repository navigation
Remove flattenTypes from readAnalysisOptionsFromJaspFile - #26
Merged
Merged
Conversation
flattenTypes (jasp-stats#20) was added for jaspTools' analysisOptions(<file>.jasp), which split the saved {value, types} options into <name> and <name>.types. jaspTools now gives the saved options as they are: the QML form of the analysis reads that shape, and it runs an analysis of a .jasp file through jaspBase::runWrappedAnalysis. Nothing else used it, so the argument and the internal flattenedAnalysisOptionsFromJaspFile go. The nested <name>.types that the option encoder writes are still dropped with includeTypeOptions = FALSE, for the runtime options. Version 1.4.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Removes the
flattenTypesargument ofreadAnalysisOptionsFromJaspFile()and the internalflattenedAnalysisOptionsFromJaspFile()(added in #20).flattenTypesonly existed for jaspTools'analysisOptions(<file>.jasp), which split the saved{value, types}options into<name>and<name>.types. jaspTools (jasp-stats/jaspTools#101) now gives the saved options as they are: the QML form of the analysis reads that shape. It also runs an analysis of a .jasp file throughjaspBase::runWrappedAnalysis()with the options as saved. Nothing else calls it.includeTypeOptions = FALSEstill drops the<name>.typesthat the option encoder writes next to a nested option, for the runtime options.Version 1.4.4. This follows #24 (1.4.2) and #25 (1.4.3), so the version line may conflict trivially.
Merge order
jaspTools
masterstill callsreadAnalysisOptionsFromJaspFile(flattenTypes = TRUE). Merge this after jasp-stats/jaspTools#101.The SyntaxInterface export
syntaxBridgeFlattenedAnalysisOptionsFromJaspFileStatusin jasp-desktop is left alone: released versions of jaspSyntax still call it.Tests
On a build of #24 + #25 + this: 490 expectations, 2 failures, both in
test-dataset-info.R. These also fail onmasterwith the released native library. jaspTools' suite (#101) passes against it: 1039 expectations, 0 failures.🤖 Generated with Claude Code