Align cdiv behavior for negative numbers between Python and JAX paths. - #40198
Open
copybara-service[bot] wants to merge 1 commit into
Open
Align cdiv behavior for negative numbers between Python and JAX paths.#40198copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
This change updates the cdiv implementation in pallas/utils.py to use truncation division instead of floor division when evaluating with Python integers (the is_dim path). This ensures consistency with the JAX lax.div path, which also uses truncation division. A new test suite is added to verify cdiv behavior across various inputs, JIT compilation, and property-based tests. PiperOrigin-RevId: 970570489
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align cdiv behavior for negative numbers between Python and JAX paths.
This change updates the cdiv implementation in pallas/utils.py to use truncation division instead of floor division when evaluating with Python integers (the is_dim path). This ensures consistency with the JAX lax.div path, which also uses truncation division. A new test suite is added to verify cdiv behavior across various inputs, JIT compilation, and property-based tests.