Refactor xla::ifrt::ArraySpec from a struct to a class - #40239
Open
copybara-service[bot] wants to merge 1 commit into
Open
Refactor xla::ifrt::ArraySpec from a struct to a class#40239copybara-service[bot] wants to merge 1 commit into
xla::ifrt::ArraySpec from a struct to a class#40239copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_971355727
branch
2 times, most recently
from
August 26, 2026 22:18
fd660a9 to
45ef7c5
Compare
- Make `dtype_`, `shape_`, `sharding_`, and `layout_` private members and provide const accessors. - Provide a 4-argument constructor `ArraySpec(DType dtype, Shape shape, ShardingRef sharding, absl_nullable std::shared_ptr<const xla::PjRtLayout> layout)` and remove the default constructor. - Update callers to use the new constructor and accessors. PiperOrigin-RevId: 971355727
copybara-service
Bot
force-pushed
the
test_971355727
branch
from
August 27, 2026 00:02
45ef7c5 to
5b58108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
xla::ifrt::ArraySpecfrom a struct to a classdtype_,shape_,sharding_, andlayout_private members and provide const accessors.ArraySpec(DType dtype, Shape shape, ShardingRef sharding, absl_nullable std::shared_ptr<const xla::PjRtLayout> layout)and remove the default constructor.