Skip to content

fix(release): allow nested hotfix branch names in release-it - #2189

Open
paustint wants to merge 1 commit into
mainfrom
fix/release-it-nested-hotfix-branches
Open

paustint wants to merge 1 commit into
mainfrom
fix/release-it-nested-hotfix-branches

Conversation

@paustint

Copy link
Copy Markdown
Contributor

release-it checks requireBranch with wildcard-match, where * doesn't cross a /. So hotfix/* rejected hotfix/nodejs/24.22.1:

ERROR Must be on branch main,hotfix/*

This switches hotfix/* to hotfix/** in .release-it.json, .release-it-desktop.json and .release-it-web-ext.json, so release-it now accepts the same branches as the ^hotfix/ guard in release.yml / sfdx-release.yml.

Checked against release-it 21.1.0's matcher: main, hotfix/x and hotfix/nodejs/24.22.1 match; hotfixes and feat/x don't.

release-it matches requireBranch with wildcard-match, where * stops at /,
so hotfix/nodejs/24.22.1 was rejected. Use hotfix/** in all three configs
to match the workflow's ^hotfix/ guard.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant