[adamecker]

feat(chores): routine card button completes the whole routine while steps remain

Summary

A routine's card used to show a faint up-chevron while steps were still to do, and that button did nothing until the routine was finished — it only folded the steps away and back. That was confusing at the top level of the card: a control that looks tappable but is inert.

Now the button always does something: while any step remains, it is a check button that marks the whole routine done; once finished, it goes back to folding the steps away and back.

What it includes:

• Complete-all button. An unfinished routine shows a check button ("Mark all of {{name}} done"). Tapping it ticks each remaining step through the normal step-tick path, so the last tick completes the chore exactly as if each step had been tapped by hand — streak and on-time are computed the same way. There is no separate force-complete path.
• Fold button once finished. A finished routine keeps the expand/collapse button as before: the card folds to just the streak and on-time chips, and a parent can open the steps to look them over. Unticking a step in the opened list reopens the routine with the other ticks kept.
• Expired routines ask a parent once. Past a routine's end time plus its expiry, the complete-all button still works, but it ticks nothing until a parent approves — one "Too late… mark it done anyway?" approval for the whole routine, not one per step. That mirrors the existing single-step expired flow, so the parental gate is never bypassed.

Screenshots (demo data):

Unfinished routine shows the check button instead of the faint chevron:

Tapping it completes all steps; the card folds to the finished state with streak and on-time chips:

Unticking one step reopens the routine with the other ticks kept:

The finished card's button still folds the steps away and back:

Expired routine: complete-all asks a parent once before ticking anything:

Verified with the client test suite green (routineSteps 8/8, full client suite 970 tests, i18n check passing) and an end-to-end pass covering: unfinished card shows the enabled check button; one tap completes all steps and folds the card to the finished chips; unticking a step reopens it with the other ticks kept; the finished button folds and unfolds the steps; an expired routine asks a parent once and completes only after approval.

Generated with Muse AI 🤖

[jherforth]

This conflicts with @mrramam merged #374. A universal complete action for the entire routine was removed.

[mrramam]

I'm okay with it. I mostly didn't want to ruin the timestamp on a routine when expanding it to examine it.

[mrramam]

One small thing: the two approve callbacks in completeRoutine return quietly when tickRemainingSteps gives false or 'expired'. The approval dialog only shows approveFailed when the callback throws, so a failed approval closes as if it worked and the routine stays open. tickRoutineStep throws Not approved there; doing the same here would match it.

Nit: the celebration could check done.completed, as tickRoutineStep checks after?.completed.

[adamecker]

@mrramam Good catch — fixed in ba46cf0. Both approve callbacks in completeRoutine now throw Not approved when tickRemainingSteps gives false or 'expired', so a failed approval shows approveFailed instead of closing as if it worked. The celebration now checks done.completed too, matching tickRoutineStep. Added tests covering the throw on both failure paths.