test merge dev into main - #2
Open
jimmielin wants to merge 3 commits into
Open
Conversation
Originator(s): @mwaxmonsky (very lightly edited by @jimmielin) Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number): - refactor and cleanup of Holtslag-Boville PBL scheme. List all namelist files that were added or changed: N/A List all files eliminated and why: N/A List all files added and what they do: N/A List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) ``` M phys_utils/atmos_phys_pbl_utils.F90 - moved minimum kvf limiter to HB logic instead of in common PBL utils code. M schemes/holtslag_boville/holtslag_boville_diff.F90 - various refactoring and cleanup of HB PBL scheme into pure elemental functions. ``` List all automated tests that failed, as well as an explanation for why they weren't fixed: None (B4B) Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc? B4B as tested in CAM against 64_137 If yes to the above question, describe how this code was validated with the new/modified features:
) Originator(s): @jimmielin Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number): - implements energy checker support for ZM deep convection - closes ESCOMP#192 List all namelist files that were added or changed: N/A List all files eliminated and why: N/A List all files added and what they do: ``` A schemes/zhang_mcfarlane/zm_prepare_flux_for_check_energy.F90 A schemes/zhang_mcfarlane/zm_prepare_flux_for_check_energy.meta - new interstitial scheme to combine liquid and ice fluxes from ZM for energy checker ``` List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) ``` M suites/suite_cam4.xml M suites/suite_cam7.xml - add calls to new interstitial scheme and energy checker in CAM4 and CAM7 suite ``` List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc? B4B but new functionality - energy checker now runs and checks fluxes from ZM. If yes to the above question, describe how this code was validated with the new/modified features: --------- Co-authored-by: Jesse Nusbaumer <nusbaume@ucar.edu>
jimmielin
force-pushed
the
development
branch
2 times, most recently
from
June 1, 2026 15:25
bd85392 to
5767c92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.