Skip to content

build: make schema properties order stable - #3984

Merged
jknack merged 1 commit into
jooby-project:mainfrom
kliushnichenko:fix/stable-schema-props-order
Jul 29, 2026
Merged

build: make schema properties order stable#3984
jknack merged 1 commit into
jooby-project:mainfrom
kliushnichenko:fix/stable-schema-props-order

Conversation

@kliushnichenko

Copy link
Copy Markdown
Contributor

Now, with openapi.yaml in the repo, I also noticed that the spec is not always reproducible. A typical issue involves a boolean field/getter that causes properties to "jump" in the schema upon rebuild. This is a try to fix it without forcing an alphabetical order everywhere (trying to avoid an avalanche of changes in the existing OpenAPI specs)

@jknack jknack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never saw it. What OS and Java SDK are you running?

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.15%. Comparing base (45d6975) to head (073d69d).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3984      +/-   ##
============================================
- Coverage     94.17%   94.15%   -0.02%     
+ Complexity     6652     6651       -1     
============================================
  Files           432      432              
  Lines         20893    20893              
  Branches       2096     2096              
============================================
- Hits          19675    19672       -3     
- Misses          760      764       +4     
+ Partials        458      457       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jknack jknack added the build label Jul 29, 2026
@jknack jknack added this to the 4.5.4 milestone Jul 29, 2026
@jknack jknack changed the title make schema properties order stable build: make schema properties order stable Jul 29, 2026
@kliushnichenko

Copy link
Copy Markdown
Contributor Author

Windows 11, OpenJdk 21. It literally pops up only for a boolean field with a getter named is*. Everything else works perfectly

@jknack
jknack merged commit 7057674 into jooby-project:main Jul 29, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants