Repository navigation
fix(uxcat): certificate name follows the certificate, not the viewer - #258
Conversation
The full-name override was keyed on the signed-in viewer, so that account read its own name on every certificate and no other viewer saw it on the right one. It is now keyed on the certificate's address. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Claude finished @manager's task in 15s —— View job Review of PR #258
Summary The change itself is correct. The name override is now keyed on the certificate's own address ( Main concern (inline comment posted): the override hardcodes a private person's full legal name and username in a public repository. Per the "This repository is public" rule in CLAUDE.md, a pushed commit stays fetchable by SHA even after a force-push. I recommend moving the override into the CMS as a per-certificate display-name field. If it has to stay in code, the earlier commit that introduced it (and this one) would need to be purged from history, which a force-push alone does not do. Minor: Not checked: I couldn't diff against |
| // the certificate's own address, so every viewer reads the same name and no | ||
| // other certificate carries it. | ||
| const name = | ||
| uxcatUserInfo?.user?.id === 1034 | ||
| String(userId).toLowerCase() === 'tufuka48' |
There was a problem hiding this comment.
This puts a private person's full legal name (plus their username) into a public repo. The name stays fetchable by SHA even after a force-push, and this is the pattern the "repository is public" rule in CLAUDE.md warns about. The comparison is also a hardcoded special case in page code.
Better to store the display name in the CMS on the certificate record (e.g. a displayName override) and use certificate?.displayName || \${certificate?.name} ${certificate?.surname}``. That way no personal data lives in the tree. If the name must stay in code for now, it still needs to come out of the git history before this merges.
Also, certificate can be null here, so the fallback renders "undefined undefined" before the 404 branch. That's harmless today because of the early return, but it is cleaner to compute name after the !certificate check.
|
Agreed on the personal data point. The name is already in the history of |
…r shared cache header The UX Core API page and the legacy redirect route answered with s-maxage=31536000, so a CDN kept their HTML across releases. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Claude finished @manager's task in 14s —— View job Review of PR #258 (updated for the new cache commit)
Summary
Still open (from the earlier review, which you've already agreed with)
Suggestions
Not checked: I didn't run lint or the app, and I couldn't confirm cache headers in a running build. |
A request for /index lands on the legacy route. Its answer had no interval, and the framework stores that under the home page route key. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Claude finished @manager's task in 13s —— View job Review of PR #258 (updated for commit 7dd0601)Summary The new commit changes Still open
Suggestions
Not checked: I couldn't diff against |
|
Merging on the owner's authorization of 2026-11-11. The cache fix was proven on staging: after a request for |
Second batch, site part. Not merged: waits for the owner's go.
What changes
/indexis answered by the catch-all page, and Next.js files its refresh timing under the same key as the home page. The catch-all returnednotFoundandredirectwithoutrevalidate, so one such request made the home page ships-maxage=31536000and stop regenerating until the next restart. Every return insrc/pages/[page].tsxnow carriesrevalidate: 10, the home page interval./uxcore-apipage. It had norevalidateand shipped the same one-year shared cache header. It now usesrevalidate: 60; the page changes rarely, so the longer interval is intended.Checks
prettierclean on the changed files,type-checkgreen in CI.main:/answerss-maxage=10, then after one request for/indexit answerss-maxage=31536000withx-nextjs-cache: HITon every later request;/uxcore-apianswerss-maxage=31536000./index,/en/indexand an unknown address,/keepss-maxage=10;/uxcore-apianswerss-maxage=60.🤖 Generated with Claude Code