Skip to content

fix: certificate name follows the certificate; home page keeps its refresh interval (staging) - #259

Merged
manager merged 3 commits into
devfrom
fix/security-batch-2-staging
Nov 11, 2026
Merged

manager merged 3 commits into
devfrom
fix/security-batch-2-staging

Conversation

@manager

@manager manager commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Staging copy of #258: the same three commits on top of dev. Authorized by the owner on 2026-11-11.

See #258 for what changes and the local proof run.

🤖 Generated with Claude Code

manager and others added 3 commits November 11, 2026 15:53
The full-name override was keyed on the signed-in viewer, so that account
read its own name on every certificate and no other viewer saw it on the
right one. It is now keyed on the certificate's address.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…r shared cache header

The UX Core API page and the legacy redirect route answered with
s-maxage=31536000, so a CDN kept their HTML across releases.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
A request for /index lands on the legacy route. Its answer had no
interval, and the framework stores that under the home page route key.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Claude finished @manager's task in 14s —— View job


Review of #259

  • Read diff against origin/dev
  • Posted inline comment

Summary

  • [page].tsx: adding revalidate: 10 to every return (notFound and redirect) is correct and well explained. It stops /index requests from overwriting the home page's refresh timing.
  • uxcore-api/index.tsx: revalidate: 60 fixes the one-year shared cache header. Fine.
  • certificate.tsx: removing the viewer-dependent GlobalContext lookup is the right fix, since the name now follows the certificate. However, it hardcodes a private person's full legal name and handle in a public repo (see inline comment). I recommend moving the override into the CMS, or at least confirming the holder's consent.

No App Router, styling, import-order, or UX Core data issues found. I did not run the build or tests.

Note: per CLAUDE.md, merging to dev (staging) needs Wolf's direct word. The PR description cites authorization from 2026-11-11.

const name =
uxcatUserInfo?.user?.id === 1034
String(userId).toLowerCase() === 'tufuka48'
? 'Кузнецов Тимофей Юрьевич'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commits a private person's full legal name and their account handle to a public repo (CLAUDE.md: "This repository is public"; the name stays fetchable by SHA even after a force-push). The old id check carried the same name, but moving it next to the public handle makes the pairing explicit. Better to store the override in the CMS (a displayName field on the certificate) so the name never enters the tree. If it has to stay in code, get the holder's consent for publishing it and confirm Wolf accepts this.

Minor: String(userId).toLowerCase() is fine, but make sure the route param is the handle and not the numeric id, otherwise this never matches.

@manager

manager commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

Read. The name and the handle are already together in the history of main and dev, so this change adds no new exposure; it makes the certificate show the right name to every viewer. Taking the name out of the tree stays an open decision for the owner and is tracked on #258. The route param is the handle. Merging on the owner's authorization of 2026-11-11.

@manager
manager merged commit 1e4735b into dev Nov 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant