Repository navigation
feat(LAB-4964): parse audio labels and their segment classifications - #2152
RuellePaul merged 2 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
RuellePaul
left a comment
There was a problem hiding this comment.
Review Summary
Verdict: Needs changes
| Severity | Count |
|---|---|
| Required | 1 |
Tested locally: tests 1338 passed, 8 of the 10 new ones red on main · parsed_label on 20 labels of the sandbox (predictions, labels, a review, with and without speakers), 20/20 round trips · 4 edge shapes, 1 raising — report
parsed_label now reads audio labels and their segment classifications as the ticket asks; one shape the API accepts and serves still raises.
reviewing-feature · 9f26d30
RuellePaul
left a comment
There was a problem hiding this comment.
Review Summary
Verdict: Ready to merge
Tested locally: tests 1339 passed · the label that raised ("children": null) now dumps and prints against the sandbox · report
Re-review: ✔ fixed in c6a86f1 — to_dict() keeps a null children as given, one test added. CI: 14 checks pass; build-test fails on staging refusing the job's API key, and fails the same way rerun on the previous commit — not this diff, the key is to renew.
reviewing-feature · c6a86f1
A parsed audio label no longer fails on the speakers key. A segment exposes its transcription, its times, its speaker and, under children, its answers to the segment-level classification jobs. The audio tutorial documents the segment-level classification.
c6a86f1 to
aeb7c53
Compare
RuellePaul
left a comment
There was a problem hiding this comment.
Review Summary
Verdict: Ready to merge
Tested locally: tests 1060 passed (tests/unit) · checks 15/15 at this head · parsed_label against the sandbox (kili!14948 at b70cb0dfe3, json-validator!220): each input type of a segment-level job read, a category changed, one added, one the job lacks refused, a first answer given through children = {…}; the dump appended back is served identical — report
Deep review after the rebase on main: no new finding.
reviewing-feature · aeb7c53
LAB-4964 — an audio segment now carries its classifications under
children(kili!14948). Import and export already pass thejsonResponsethrough; the label parser did not read audio labels at all.parsed_labelworks on audio labels. It raisedJobNotExistingError: Job named 'speakers' does not existon every audio label, the backend always writingspeakersat the root. The key is now read as the speakers of the label, and kept byto_dict().text,start_time,end_time,speaker_id,mid, andchildren— its answers to the segment-level classification jobs (rootCLASSIFICATIONjobs withoutlevel). Those jobs are no longer listed at the root of the parsed label.recipes/audio_projects.ipynband its generated page document the segment-level classification, import it with the pre-annotations and read it back throughparsed_label.Verification
pytest:1339 passed, 1 skipped, 1 xfailed, with 11 new tests intest_resp_parsing_audio.py.mkdocs build:PASSED.build-testfails, twice: staging refuses the API key the job signs in with (AuthenticationFailed). Rerun on the previous commit, where it passed the day before, the job fails the same way: the key, not this diff.2 2.3 <speaker id> Hello.and its emotionNEUTRAL."children": null, which the API accepts and serves, madeto_dict()raiseAttributeError; fixed inc6a86f14, and the sandbox's label that raised now dumps and prints.Decided
speakersis not a job: it is skipped by the job check on anAUDIOlabel only, and any other input type still raises on it.segment.childrenraisesKeyErroron a segment that has none, as an object annotation without sub-job does today.Open
level).