Repository navigation
fix(parse): reject incomplete format matches - #152
Open
awais-ur-rehman wants to merge 1 commit into
Open
awais-ur-rehman wants to merge 1 commit into
awais-ur-rehman wants to merge 1 commit into
Conversation
knowledgecode
self-requested a review
November 3, 2026 08:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parsing
2025againstYYYY-MM-DDcurrently succeeds even though the month and day are absent. Record required-token matching failures inpreparseand reject them in the shared validator used byparseandisValid, while preserving parsed components and intentional short formats or ellipsis.PreparseResultgains an optional_error: truefield on mismatches; successful result shapes are unchanged.Breaking changes
None.
PreparseResultadds an optional error flag on failed matches.Testing
Added 20 regression cases, with nine cases failing before the fix. Full
npm testpasses all 2373 tests after rebuilding;npm run lint,npm run ts,npm run build, andgit diff --checkpass on Node 24/macOS. Other runtime/platform combinations were not exercised locally.Manual check:
isValid("2025", "YYYY-MM-DD")returns false andparsereturns an invalid Date; the same input withYYYYremains valid.AI assistance
OpenAI Codex assisted with investigation, implementation, regression tests, review, and validation.