Repository navigation
Fix the panel at the root without a trailing slash - #2
Merged
Merged
Conversation
Under a path base, the app's own address without the trailing slash (/app) has an empty request path, which Reiho cannot cut the route's "/" from: a signed-in user of the Polyglot demo got 500 at kododo.dev/polyglot/demo. The panel at the root now treats an empty path as "/".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under a path base, the app's own address without the trailing slash (
/app) has an empty request path. Reiho cannot cut the route's/from it and throwsArgumentOutOfRangeException. As a result, a signed-in user of the Polyglot demo got 500 atkododo.dev/polyglot/demo, whilekododo.dev/polyglot/demo/worked.The panel at the root now treats an empty path as
/. Only the root panel was affected: Ways and a panel at a path such as/adminmatch their address without the slash through the catch-all.Tests
Panel_AtTheRoot_IsTheHomePage_NextToTheHostsEndpoints: the bare path base answers 200 with the panel page. It failed before the fix. 53 tests pass on net8.0, net9.0 and net10.0./polyglotwithout the slash), browser scenarios 33/33, and the bare address answers 200 after sign-in.