[yue9944882]

Bug

io.kubernetes.client.custom.Quantity violates the Object.equals/hashCode contract.

• equals() compares the underlying BigDecimal by value (ObjectUtils.compare → BigDecimal.compareTo, which is scale-insensitive).
• hashCode() used Objects.hash(number), i.e. BigDecimal.hashCode(), which is scale-sensitive.

So value-equal quantities with different scales are equals() but have different hash codes. Example via the public API:

Quantity a = Quantity.fromString("1");      // scale 0
Quantity b = Quantity.fromString("1000m");  // 1000 * 10^-3 = 1.000, scale 3
a.equals(b);          // true
a.hashCode() == b.hashCode(); // false  <-- contract violation

This breaks HashMap/HashSet membership for Quantity keys (a value inserted as 1000m is not found when looked up as 1).

Fix

One line: normalize the scale with BigDecimal.stripTrailingZeros() before hashing, making the hash consistent with the value-based equals(). Null-guarded. Behavior-preserving otherwise.

Verification

Added a focused unit test QuantityTest.equalQuantitiesWithDifferentScaleHaveEqualHashCode.

• Before fix: FAILS — expected: <62> but was: <31034>.
• After fix: PASSES.
• No regressions: QuantityTest (2), QuantityFormatterTest (20), SuffixFormatterTest (16) all green.

./mvnw -pl kubernetes -am test -Dtest=QuantityTest

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment