Repository navigation
[kubernetes] Format negative quantities with SI/binary suffixes - #4956
Merged
kubernetes-prow[bot] merged 1 commit intoOct 23, 2026
Conversation
kubernetes-prow
Bot
added
the
do-not-merge/work-in-progress
kubernetes-prow
Bot
added
approved
QuantityFormatter.removeFactorsForBase used result.compareTo(base) >= 0 as the loop guard, which is always false for negative unscaled values, so negative quantities were never reduced to a suffixed form. As a result Quantity.toSuffixedString() returned e.g. "-100000" instead of "-100k" and "-1048576" instead of "-1Mi". Guard on the absolute value so the factor-removal loop runs for negative magnitudes too. BigInteger.mod already returns a non-negative remainder and divide handles negative values, so the divisibility check and downstream exponent math are unchanged for positive inputs. Add focused unit tests covering negative DECIMAL_SI and BINARY_SI formatting (fail before, pass after).
yue9944882
force-pushed
the
fix/core-negative-quantity-suffix
branch
from
October 22, 2026 17:27
7bc00df to
ac0b1c6
Compare
kubernetes-prow
Bot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
brendandburns
marked this pull request as ready for review
October 23, 2026 14:00
kubernetes-prow
Bot
removed
the
do-not-merge/work-in-progress
kubernetes-prow
Bot
merged commit Oct 23, 2026
98927e0
into
kubernetes-client:master
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
QuantityFormatter.removeFactorsForBase used result.compareTo(base) >= 0 as its loop guard. For a negative unscaled value that comparison is always false, so the factor-removal loop never ran for negative quantities and they were never reduced to a suffixed form.
As a result Quantity.toSuffixedString() produced unsuffixed output for negative values:
Minimal fix
Guard on the absolute value: while (result.abs().compareTo(base) >= 0 && ...). BigInteger.mod already returns a non-negative remainder and BigInteger.divide handles negative values, so the divisibility check and the downstream exponent / multiple-of-3 math are unchanged for positive inputs. Behavior-preserving except for the bug; one-line change.
Verification
Added two focused unit tests in QuantityFormatterTest (formatNegativeDecimalSi, formatNegativeBinarySi). They fail before the fix (expected "-100k" but was "-100000"; expected "-1Mi" but was "-1048576") and pass after.
./mvnw -pl kubernetes -am test -Dtest=QuantityFormatterTest,QuantityTest,SuffixFormatterTest