docs(readme): surface the security policy from the README - #577
Conversation
The security policy in .github/SECURITY.md is only discoverable through GitHub's Security tab. Mirror ethrex's README section so the reporting channels are visible to anyone reading the repo front page.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
🤖 Kimi Code ReviewThis is a documentation-only change adding security disclosure channels. No consensus-critical code is modified. README.md
The change follows standard responsible disclosure practices and is appropriate for a consensus client. No blockers. Automated review by Kimi (Moonshot AI) · kimi-k2.5 · custom prompt |
🤖 Claude Code ReviewThis PR is documentation-only (README.md addition), so the consensus-layer/code-correctness checklist doesn't apply. A quick review of the change itself: ReviewContent is accurate and low-risk.
Minor nitpick (non-blocking): the PR body's verification checklist has all three boxes ( No correctness, security, performance, or Rust-idiom concerns — there's no code in this diff. Good to merge. Automated review by Claude (Anthropic) · sonnet · custom prompt |
🤖 Codex Code ReviewNo findings. This PR is documentation-only. It adds a security reporting section in README.md and does not touch fork choice, attestation handling, justification/finalization, state transition, XMSS verification, SSZ, or any Rust execution path, so I do not see a correctness, security, performance, or memory-safety regression from this diff. I also verified that the referenced policy file exists at .github/SECURITY.md and is consistent with the new README text. The only residual note is that I could not validate the rendered GitHub behavior of the Automated review by OpenAI Codex · gpt-5.4 · custom prompt |
🗒️ Description / Motivation
Aligns ethlambda with ethrex's security policy setup.
.github/SECURITY.mdalready exists here and is byte-identical to ethrex's (modulo two trailing-whitespace differences, which ours does not have), so no changes were needed to the policy itself. What was missing is ethrex's README pointer to it: the policy was only reachable through GitHub's Security tab, so anyone reading the repo front page had no idea where to report a vulnerability.What Changed
README.md: new## Securitysection, placed just before## Contributingto match ethrex's ordering. Text is copied from ethrex's README section verbatim, including the repo-relative../../security/advisories/newadvisory link (which resolves correctly under this repo) and thesecurity@lambdaclass.comfallback.Correctness / Behavior Guarantees
Docs only. No code, config, or build changes.
Tests Added / Run
None; documentation-only change. Verified the two new links resolve:
./.github/SECURITY.mdexists in-tree.../../security/advisories/newis the same relative form ethrex uses, resolving tohttps://github.com/lambdaclass/ethlambda/security/advisories/new.Related Issues / PRs
.github/SECURITY.md✅ Verification Checklist
make fmt— cleanmake lint(clippy with-D warnings) — cleanmake test(cargo test --workspace --profile release-fast) — all passing(Not run: no Rust sources touched.)