Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/sdk/server/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,12 @@ ext {
ext.libraries = [:]

ext.versions = [
"checkerQual": "3.33.0",
"commonsCodec": "1.19.0",
"gson": "2.13.1",
"guava": "32.0.1-jre",
"guava": "33.8.0-jre",
"jackson": "2.11.2",
"jsr305": "3.0.2",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers:

Guava 33.x dropped its jsr305 and checker-qual dependencies (it moved to JSpecify), and the SDK's own source imports those annotations and had been getting them transitively. I added both to libraries.internal pinned to the exact versions Guava 32.0.1 supplied (jsr305 3.0.2, checker-qual 3.33.0, they were already embedded and shaded in the released uberjar, so the jar contents stay the same rather than gaining anything new.

"launchdarklyJavaSdkCommon": "2.3.0",
"launchdarklyJavaSdkInternal": "1.12.2",
"launchdarklyLogging": "1.1.0",
Expand Down Expand Up @@ -117,6 +119,10 @@ libraries.internal = [
"commons-codec:commons-codec:${versions.commonsCodec}",
"com.google.code.gson:gson:${versions.gson}",
"com.google.guava:guava:${versions.guava}",
// Guava 33.x stopped depending on jsr305 and checker-qual, which our code uses and which
// were previously embedded transitively, so now we declare them directly.
"com.google.code.findbugs:jsr305:${versions.jsr305}",
"org.checkerframework:checker-qual:${versions.checkerQual}",
"com.squareup.okhttp3:okhttp:${versions.okhttp}",
"com.launchdarkly:okhttp-eventsource:${versions.okhttpEventsource}",
"org.yaml:snakeyaml:${versions.snakeyaml}",
Expand Down
Loading