Repository navigation
test: Wire wrapper, proxy, context comparison and secure mode hash in the contract test service - #250
Merged
Conversation
… the contract test service Declare secure-mode-hash, whose command handler already existed, and wire and declare wrapper, http-proxy and context-comparison, so that the harness runs those tests on v2 and v3. Generated-by: termag
kinyoklion
marked this pull request as ready for review
November 3, 2026 17:51
keelerm84
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The server contract test service now declares four capabilities that the SDK already supports, so the harness runs their tests on v2 and v3:
secure-mode-hash: thesecureModeHashcommand was already handled, only the capability was missing.wrapper: maps the harness'swrapperconfig ontoLDConfig.Builder.wrapper. The harness sends""for an unset name or version, so the service treats an empty string as unset.http-proxy: mapsproxy.httpProxyontoHttpConfigurationBuilder.proxyHostAndPort.context-comparison: adds thecontextComparisoncommand, which builds both contexts and returnsLDContext.equals.Tested locally against harness v2.41.1 and v3.2.0-alpha.15 with the CI suppression files: 33 newly run tests pass on each version, and every test that passed before still passes.
Opened from termag
Note
Overview
The server contract test service is updated so the harness can exercise SDK features that were already implemented but not advertised or fully wired.
Capabilities added to the status endpoint:
context-comparison,http-proxy,secure-mode-hash, andwrapper. Forsecure-mode-hash, only the capability string was missing—thesecureModeHashcommand path was already in place.Config mapping on client creation: harness
wrappername/version map toLDConfig.Builder.wrapper, with empty strings normalized to null (the harness sends""for unset values).proxy.httpProxymaps toHttpConfigurationBuilder.proxyHostAndPort.New command
contextComparison: builds two contexts from harness params (single or multi, attributes, literal/path private attributes) and returns whetherLDContext.equalsholds between them.Reviewed by Cursor Bugbot for commit 1ab7fc4. Bugbot is set up for automated code reviews on this repo. Configure here.