Skip to content

fix: Measure synchronizer deadlines with a monotonic clock - #253

Open
beekld wants to merge 1 commit into
bklimt/SDK-3402/retry-parkingfrom
bklimt/SDK-3402/monotonic-deadlines
Open

beekld wants to merge 1 commit into
bklimt/SDK-3402/retry-parkingfrom
bklimt/SDK-3402/monotonic-deadlines

Conversation

@beekld

@beekld beekld commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The FDv2 synchronizer loop measured its deadlines against the wall clock. When the system clock stepped backwards, every pending deadline was delayed by the size of the step. If every synchronizer was parked for 5 minutes and the clock stepped back an hour, no synchronizer ran for 65 minutes.

These deadlines now use MonotonicTime, a small value class over System.nanoTime(), so changes to the system clock don't move them.

Stacked on #252.


Note

Overview
What changes

FDv2 synchronizer deadlines (recovery, fallback, wake scheduling), FDv1 fallback end times, and synchronizer park/unpark times now use a new MonotonicTime type backed by System.nanoTime(), so system clock adjustments no longer stretch or shrink those waits.

awaitUntil, earliest, and buildNextAvailableSynchronizer idle waits use monotonic durations (until) instead of Duration.between(Instant.now(), …).

Adds MonotonicTime ( now, plus, isBefore with overflow-safe comparison, until ) and MonotonicTimeTest for nanosecond overflow edge cases.

Risk for reviewers: Verify all call sites that compared or stored these deadlines now consistently use MonotonicTime and that nothing still mixes Instant for the same logical deadlines.

Reviewed by Cursor Bugbot for commit 5198a56. Bugbot is set up for automated code reviews on this repo. Configure here.

@beekld
beekld added this pull request to stack #254 November 6, 2026 03:27
@beekld
beekld marked this pull request as ready for review November 6, 2026 03:27
@beekld
beekld requested a review from a team as a code owner November 6, 2026 03:27
@beekld
beekld force-pushed the bklimt/SDK-3402/monotonic-deadlines branch from b97b53a to 7a1fa34 Compare November 6, 2026 03:36
@beekld
beekld force-pushed the bklimt/SDK-3402/monotonic-deadlines branch from 7a1fa34 to 5198a56 Compare November 6, 2026 17:37

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants