Repository navigation
Conversation
UpdateProcessor now declares start and stop directly. Custom UpdateProcessor implementations no longer need to define is_alive. Code that referenced BackgroundOperation must drop that reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateProcessornow declaresstartandstopitself and no longer inherits fromBackgroundOperation, which is removed. CustomUpdateProcessorimplementations no longer need to defineis_alive, and code that importsBackgroundOperationmust drop that import.Note
Overview
This is a breaking public API change: the internal
BackgroundOperationhelper is deleted, andUpdateProcessorno longer inherits it.UpdateProcessornow definesstartandstopdirectly (with updated docstrings) and no longer documents or requiresis_alive.Built-in no-op and test doubles are updated to match:
NullUpdateProcessor,NullEventProcessor, andAsyncNullEventProcessorinstubs.py, plusMockUpdateProcessor,MockEventProcessor, andMockAsyncUpdateProcessordrop theiris_aliveimplementations. CustomUpdateProcessorimplementations and any code importingBackgroundOperationmust be updated accordingly.Reviewed by Cursor Bugbot for commit 1ed1fb8. Bugbot is set up for automated code reviews on this repo. Configure here.