Repository navigation
test: Wire wrapper and service endpoint options and declare TLS peer verification in the contract test service - #481
Merged
Conversation
…verification in the contract test service Generated-by: termag
kinyoklion
marked this pull request as ready for review
November 3, 2026 17:54
keelerm84
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The contract test service now maps
configuration.wrappertowrapper_name/wrapper_version(an empty name or version counts as unset) andconfiguration.serviceEndpointstostream_uri/base_uri/events_uri, and streams by default when onlyserviceEndpoints.streamingis given. It declareswrapper,service-endpointsandtls:verify-peer, so the harness now runs the wrapper header tests,events/disabling,service endpoints/using separate service endpoints properties(v2) and the threeinvalid tls certificatetests. The SDK verifies peers by default, so TLS needs no mapping.Tested locally against harness v2.42.0 and v3.2.0-alpha.15 with persistence tests enabled: every newly run test passes and no test that passed on main fails or disappears.
Opened from termag
Note
Overview
The contract test ClientEntity now maps harness
configuration.serviceEndpointsonto SDKstream_uri/base_uri/events_uri(applied early; legacy streaming/polling/events blocks can still override). When there is nodataSystem,streaming, orpollingblock,use_lddis enabled only ifserviceEndpoints.streamingis absent—so a streaming-only endpoint config can drive live updates without an explicit streaming section.configuration.wrapperis mapped towrapper_nameandwrapper_version, treating empty strings as unset.The test service advertises
wrapper,service-endpoints, andtls:verify-peercapabilities so the harness runs wrapper header, separate-endpoints, events-disable, and invalid-TLS scenarios (peer verification relies on SDK defaults, not new mapping).Reviewed by Cursor Bugbot for commit 0370c08. Bugbot is set up for automated code reviews on this repo. Configure here.