Support additional geometry types, refactor geometry handling - #382
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| import org.slf4j.LoggerFactory; | ||
|
|
||
| // TODO: how to handle name collisions for id or geometry | ||
| // TODO: how to handle name collisions for id, geometry, or place |
There was a problem hiding this comment.
A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.
TODO: how to handle name collisions for id, geometry, or place
- Ignore
Contributor
Author
There was a problem hiding this comment.
revisit when extending CRUD to JSON-FG
6 tasks
Collaborator
|
@cportele |
... after the unit test has been migrated
Using NaN is the typical way to encode POINT EMPTY in WKB (see, e.g., GeoPackage), so we will use it also for GML. NaN is a valid double value in XML Schema.
there is probably not much benefit by converting the classes to visitors. It just adds internal complexity.
Tests already exist; move tests to xtraplatform-geometries to the encoder/decoder
cportele
marked this pull request as ready for review
August 18, 2025 07:40
cportele
added a commit
that referenced
this pull request
Nov 27, 2025
The changes in #392 did not fully handle the new `onGeometry()` event introduced in #382. In `FeatureTokenStatsCollector` the event was not passed downstream. Closes ldproxy/ldproxy#1519.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.