tiles: skip layers without data when combining vector tiles - #596
Open
cportele wants to merge 2 commits into
Open
tiles: skip layers without data when combining vector tiles#596cportele wants to merge 2 commits into
cportele wants to merge 2 commits into
Conversation
A tileset that has no data in the area of a tile cannot contribute a layer to a combined tile, so its tile is now neither looked up in the cache nor generated. Before, a tile that was not in the cache was generated on the fly for every source tileset, which made combining a tile as expensive as generating all of its layers. - TileEncoderMvt: transform the tile bounds once per combined tile and skip a layer when the bounds of its tileset do not intersect them; an unknown extent is treated as "may have data" - TileEncoders: hand the tileset bounds and the CRS transformer factory to the encoders, which are instances now instead of a static map - TileProviderFeatures: expose the bounds of a tileset from its metadata
A job set whose tilesets are not covered by any seeded cache produces no jobs, so its total stayed unknown. That is never 100%, so the job set was neither finished nor removed from the queue: it was reported at 0% indefinitely and it suppressed every following seeding run of the tile provider. Such a job set now has a total of zero and completes through the regular cleanup.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of addressing ldproxy/ldproxy#1722
A tileset that has no data in the area of a tile cannot contribute a layer to a combined tile, so its tile is now neither looked up in the cache nor generated. Before, a tile that was not in the cache was generated on the fly for every source tileset, which made combining a tile as expensive as generating all of its layers.