Add xxd to the base CI debian image - #193
Merged
Merged
Conversation
theihor
self-requested a review
July 14, 2025 18:23
Contributor
Author
|
Oh I saw the comment on https://github.com/libbpf/ci/blob/main/setup-build-env/install_packages.sh#L15-L20 now. I will update the PR |
theihor
requested changes
Jul 14, 2025
theihor
left a comment
theihor
left a comment
Contributor
There was a problem hiding this comment.
This is a wrong place to add a selftests build dependency. See my comment: #192 (review)
Also please update a commit message and PR description appropriately. Include a link to your upstream patchset.
Thanks.
Contributor
You don't have to re-submit a PR, btw. You can force-push into your git branch. |
Contributor
Author
|
I know :) I was just shortcutting using the github UI, it's a lazyness fail, will update this PR |
xxd is used to generate a C header from a verification certificate (DER encoded) which is used to test BPF signing infrastructure in selftests.
theihor
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xxd is used to generate a C header from a verification certificate (DER encoded) which is used to test BPF signing infrastructure in selftests.