Repository navigation
Conversation
On 2026-09-04 perma-id/w3id.org moved every namespace directory from the repository root into ids/ (upstream commit 94ed72fc). from_w3id() still listed the root tree, so it returned only docs, ids and tools. A refresh would overwrite w3id.csv with those three rows, and tests/test_etl/test_w3id.py fails with KeyError 'kgcl'. List git/trees/master:ids instead. Also check the HTTP status before parsing JSON. The old error branch called .message on a dict, which turned any non-200 response (rate limit, or a future 404 if ids/ moves) into an AttributeError. Signed-off-by: jdsika <carlo.van-driesten@vdl.digital>
jdsika
force-pushed
the
fix/w3id-ids-subtree
branch
from
October 20, 2026 17:47
f14263d to
00a8d80
Compare
This was referenced Oct 21, 2026
Contributor
Author
|
@amc-corey-cox this fixes the CI. The other PRs need rebasing after merge to turn green as well |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On 2026-09-04 perma-id/w3id.org moved every namespace directory from the repository root into
ids/(upstream commit 94ed72fc, "Move hosted files and rules toids/directory."). The served URLs did not change:ids/kgcl/still serveshttps://w3id.org/kgcl/.from_w3id()still lists the root tree, so it now returns onlydocs,idsandtoolsinstead of about 2,300 namespaces. As a result:tests/test_etl/test_w3id.pyfails withKeyError: 'kgcl'.make etl, or a dispatch of the Refresh workflow (which commits and pushes), would silently overwritew3id.csvwith those three rows.Change
git/trees/master:idsinstead of the root tree. The call works unauthenticated, returns 2,309 entries and is not truncated.results.messageon a dict, so any non-200 response (an unauthenticated rate limit, or a 404 ifids/ever moves) raised anAttributeErrorinstead of a clear error. It now raisesValueErrorwith the URL, status code and body.This PR does not regenerate
w3id.csv. The committed data is intact and matches upstream as of June 2026.Verification
pytest tests/test_etl/test_w3id.pypasses. The full suite passes locally.w3id.csv: 326 added and 3 gone. All three are real upstream changes:cppwas deleted.FAIRagrowas renamed tofairagro.linkedEarthwas renamed tolinkedearth.ValueErrorwith the status code and body.flake8with thetox -e flake8plugin set andblack --check -l 100are clean.