Move 'gap' of canplayer between frames not logs. - #619
Open
JamesB192 wants to merge 1 commit into
Open
Conversation
For when -t was too fast, and sans -t, takes too long.
JamesB192
force-pushed
the
gap-in-logs-not-between
branch
from
July 30, 2026 23:15
255a37c to
e9ceaa3
Compare
Member
|
I get your point but the patch is wrong IMO. If you have a bunch of frames that are so tight together that they are needed to be pushed out until the next waiting happens, you simply have to do so. Otherwise you will never get the correct timely behaviour. This gap setting is more like a "how often the loop is running" than describing the gap between two CAN frames. And inside such a (1ms) loop multiple CAN frames may be needed to be processed when their timestamps fit into this 1ms section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For when -t was too fast, and sans -t, takes too long.