chore: introduce DevelopmentTokenSource and deprecate SandboxTokenSource - #1149
Open
hiroshihorie wants to merge 2 commits into
Open
chore: introduce DevelopmentTokenSource and deprecate SandboxTokenSource#1149hiroshihorie wants to merge 2 commits into
hiroshihorie wants to merge 2 commits into
Conversation
Port of livekit/client-sdk-swift#1077. LiveKit Cloud renamed the sandbox token server to development token server. SandboxTokenSource stays as a deprecated subclass so the old sandboxId constructor keeps compiling. Also exclude build directories from analysis, Xcode vendors Swift package checkouts there when SPM is enabled.
hiroshihorie
marked this pull request as ready for review
August 4, 2026 07:08
hiroshihorie
requested review from
cloudwebrtc and
xianshijing-lk
as code owners
August 4, 2026 07:08
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
lukasIO
reviewed
Aug 4, 2026
MaxHeimbrock
reviewed
Aug 4, 2026
| export 'src/token_source/endpoint.dart'; | ||
| export 'src/token_source/custom.dart'; | ||
| export 'src/token_source/caching.dart'; | ||
| export 'src/token_source/sandbox.dart'; |
There was a problem hiding this comment.
Will this break clients using the old path?
Member
Author
There was a problem hiding this comment.
It's only renamed, and should be ok.
Co-authored-by: lukasIO <mail@lukasseiler.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Port of livekit/client-sdk-swift#1077. LiveKit Cloud renamed the sandbox token server to the development token server, this aligns the API:
DevelopmentTokenSource({required String id})is the new name, same endpoint and headerSandboxTokenSourceremains as a deprecated subclass. Unlike Swift, a typealias is not enough here because the old constructor takessandboxId:while the new one takesid:, so the subclass keeps existing call sites compiling unchangedAlso excludes
build/from analysis, Xcode vendors Swift package checkouts there when SPM is enabled (same fix already applied to components-flutter and the agent starter).Notes
minor type="added"TokenSource.sandboxTokenServer) and has not been renamed yet, tracked separately