Repository navigation
Adds cleanup functions for resources - #224
Conversation
|
Will we need a patch release ? We use the wait_for functions in my application, |
|
No, we probably don't need a patch release for these changes. With these changes, applications will realistically be calling the Regarding the |
rhornung67
left a comment
There was a problem hiding this comment.
Seems reasonable to me. However, someone else should review and approve to make sure.
- This is a refactored version that was previously removed
|
@bechols97 @MrBurmark this branch of Camp passed all the CI checks in RAJA. Please feel free to merge it. After that, I will put up a PR for the Camp patch release. |
This is a bugfix to add cleanup functions for resources.
The Hip and Cuda resources are non-owning and never destroy streams, which show up as leaks in memory checkers/sanitizers. In these cases, the streams would be destroyed in the new cleanup function. If there is no cleanup needed for a resource (such as Host, Omp_target, Sycl), then the cleanup function will be a no-op.
An open question for this PR is whether the cleanup functions should be thread-safe? Currently, these are not thread safe to be consistent with
RAJA::release_unused_internal_memory().Note: These changes were created by AI. I have reviewed the changes and they seemed reasonable.At this point, this has been redesigned from the initial changes made by AI.
Related to: #223