Repository navigation
Fix leading multipliers in unit-string addition - #476
Open
vera-rubin wants to merge 1 commit into
Open
vera-rubin wants to merge 1 commit into
vera-rubin wants to merge 1 commit into
Conversation
Collaborator
|
This looks good. Good catch. I will merge once the tests other than coverage pass. Thanks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unit_from_string("3 ft + 2 in")returned 42 inches because the leading 3 multiplied both terms. We check addition before consuming the leading multiplier, preserving each term’s coefficient. The documented example and both reproducer forms return 38 inches.One regression test covers the expression, same-unit and chained addition, and controls for grouping and scientific notation. It fails on the original parser and passes with the fix. All 24 CTest targets passed before and after in Release mode. Formatting and whitespace checks pass.
Version: GCC 13.3.0
Fixes #475
— ChipLab