Skip to content

Replace explicit http.Client usage with specific interface #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
egor-gorlin-exinity wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replace explicit http.Client usage with specific interface #18

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
befe13b
Replace explicit http.Client usage to narrow interface.
egor-gorlin-exinity Jun 10, 2022
98aca69
Fix api events test.
egor-gorlin-exinity Jun 10, 2022
8383df2
Merge branch 'mParticle:master' into master
egor-gorlin-exinity Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion events/configuration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,18 @@ type BasicAuth struct {
APISecret string `json:"apiSecret,omitempty"`
}

type RequestDoer interface {

@abhishekdas29 abhishekdas29 Jan 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type RequestDoer interface {
type HTTPDoer interface {

I would recommend naming specific to HTTP since the interface is just in the events package. This will help the developers.

Do(req *http.Request) (*http.Response, error)
}

// Configuration stores the configuration of the API client
type Configuration struct {
BasePath string `json:"basePath,omitempty"`
Host string `json:"host,omitempty"`
Scheme string `json:"scheme,omitempty"`
DefaultHeader map[string]string `json:"defaultHeader,omitempty"`
UserAgent string `json:"userAgent,omitempty"`
HTTPClient *http.Client
HTTPClient RequestDoer
}

// NewConfiguration returns a new Configuration object
Expand Down