Sync fmsgd dd.sql for add-to batch hash identity (merge after fmsgd#35/#39) - #16
Open
markmnl wants to merge 1 commit into
Open
Sync fmsgd dd.sql for add-to batch hash identity (merge after fmsgd#35/#39)#16markmnl wants to merge 1 commit into
markmnl wants to merge 1 commit into
Conversation
msg_add_to_batch gains sha256 (batch message hash, the batch's identity); msg_add_to uniqueness relaxed to (batch_id, addr); the populate-psha256 trigger accepts a reply psha256 matching one of the parent's batch hashes. Merge only AFTER fmsgd#35 and fmsgd#39: the old fmsgd main add-to path relies on the (msg_id, addr) constraint this schema drops. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
002-fmsgd-dd.sqlfrom the fmsgdfix/batch-hash-reply-parentsbranch (markmnl/fmsgd#35 + markmnl/fmsgd#39):msg_add_to_batch.sha256(batch identity = batch message hash),msg_add_touniqueness relaxed to(batch_id, addr), and the populate-psha256 trigger accepting a replypsha256that matches one of the parent's batch hashes.Merge order: only after fmsgd#35 and fmsgd#39 merge. The old fmsgd main add-to path relies on the
(msg_id, addr)constraint this schema drops, so this PR's integration-test check is expected to fail while fmsgd#35/#39 are unmerged (the check builds fmsgd frommain). Re-run the check after those merge — it should then go green, including the new009-reply-to-add-to-batch.shregression test.To see the before/after in Actions with workflow dispatch:
main,fmsgd_ref: main→ 001–008 pass, 009 fails (the regression the fmsgd stack fixes)fmsgd-v0.5.0-dd-sync,fmsgd_ref: fix/batch-hash-reply-parents→ 9/9 pass🤖 Generated with Claude Code