Repository navigation
fix(P1.2): remove firmware update deadlock and verify SV/PTP STOP before flashing - #354
Merged
Merged
Conversation
… quiescence Remove Advanced firmware action's circular active-PTP disabled gate. Add operator confirmation and single-supervisor STOP/readback preflight that retires pending SV/profile transactions, preempts both services, requires board SVLIFE and PTP STOP proof before ROM probe, blocks new mutations during handoff, and fails closed on uncertain state. Add deterministic regression for CFG-pending plus PTP STOP_UNVERIFIED.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…ew boot Prevent maintenance quiescence from persisting into a successfully updated board and blocking future START; wake firmware preflight when prior M4 exclusive commands finish retirement.
…dden dialogs Display supervisor updateStatus from authorization through reconnect in the same Advanced panel; block port refresh during exclusive handoff, show truthful Updating status in the compact header, and close confirmation even when C++ rejects preflight so the error is visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Physical-test blocker reproduced from operator screenshots
On COM15, board reports
CFG REJECT,START not sent: device preparation timed out, andPTP STOP UNVERIFIED; Advanced > Firmware incorrectly disables the only update action until SV/PTP are stopped, although the update supervisor is the intended owner of that stop. This creates a circular recovery dependency.Production fix
SmartSessionControllernow always requests fresh both SV and PTP STOP, even when cachedrunning=false, before handing the COM to espflash. It does not trust an old RUNNING/OFF value or a STOP command being queued.DeviceController::beginFirmwareQuiescence()retires incomplete PROFILE/CFG staging, sends priority STOP and PTP STOP through the existing serial worker, and waits for board STOP ACK followed by SVLIFE STOPPED SHOW readback plus PTP STOP acknowledgement followed by PTP SHOW STOPPED. A STOP_UNVERIFIED state triggers a fresh supervised STOP, not a permanently disabled UI.Scope: Studio QML + DeviceController + sole SmartSessionController + S8 harness. No ESP-IDF changes, no conflict with LAN autonomy #330 or M4 roster #350. Preserve M3.H.3 stable.
Merge only after exact-head Windows/Linux build, S8, Qt, security and packaged preview smoke PASS. Physical STOP behavior still needs isolated board verification.