Skip to content

fix(studio): identify real Windows Ethernet adapters in SV/PTP capture - #356

Open
masarray wants to merge 1 commit into
mainfrom
fix/sv-capture-windows-nic-identity
Open

masarray wants to merge 1 commit into
mainfrom
fix/sv-capture-windows-nic-identity

Conversation

@masarray

@masarray masarray commented Nov 3, 2026

Copy link
Copy Markdown
Owner

Root cause

The capture dropdown showed raw dumpcap descriptions (Local Area Connection*) and long NPF GUIDs. Display indices were unstable across refresh; heuristic name matching could suggest virtual adapters.

Change

  • Resolve dumpcap capture IDs against Windows GetAdaptersAddresses adapter GUID; show Windows alias, hardware description and link state while retaining NPF ID for dumpcap -i.
  • Prefer a single connected physical Ethernet adapter; preserve explicit selection by stable NPF ID across restart/reorder; never guess when multiple candidates exist.
  • Show capture interface details in Studio and add deterministic Realtek/Hyper-V/ambiguous-NIC regression to existing production capture harness.
  • Add iphlpapi only to Windows Qt targets. Other platforms retain safe dumpcap fallback.

Validation

Synthetic harness added, pending GitHub CI. Physical NIC inspection and TAP/SPAN capture require Windows machine and are NOT claimed.

Scope

Independent of pending firmware lifecycle PRs #355 / #350 / #330; no firmware or TX timing changes.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-03T22:45:00.006675Z
We couldn’t complete this review. Comment @codex review to try again.
423fb5f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant