You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry for the random, minor comments.
Yet, I am already concerned by the fact that we have summable defined both in esum.v and in realsum.v: we might want to distinguish one or the other by adding a small e or a small r in the identifier.
I made a first pass. I have not yet looked at section esum_summable.
I'll complete this review asap.
Maybe we do not need pos_neq0_esum
(btw, let's keep the substring pos_esum in identifiers
so that we remember easily that we are inside the PosEsum module)
since it is not used and in fact the more general
version neq0_esum (rather: esum_neq0) does not require
non-negativity as an hypothesis
(so far, the rationale was to use the PosEsum module to hold
restricted versions of esum lemmas for non-negative functions).
pos_sum_esum_ge: we can suppress because this is really
just a special case of pos_esum_ge and is used only once.
summable_muleC is maybe not necessary since it is really
just under eq_fun do rewrite muleC
Pending: pos_esum_ge1/esum_ge1: there might be a better name
(_ge1 looks too much like 1 <= _) but I have not idea yet
esum_unit does not mention unit, maybe esum_if_eq_op_set1
but the script is so short that maybe the lemma is not really useful
TODO: the changelog should mention that le_esum has been generalized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enhancement ✨This issue/PR is about adding new features enhancing the library
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Set of lemmas for
esumextracted from #2049.Checklist
CHANGELOG_UNRELEASED.mdReminder to reviewers