Repository navigation
Optimization of Triangle Number Sum - #64
Open
davis-matthew wants to merge 1 commit into
Open
davis-matthew wants to merge 1 commit into
davis-matthew wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced summation loop of triangle sums with the closed-form formula. Originally found by matching against OEIS A000292.
Overflow will happen earlier with this version, although no reasonable order would get anywhere close so I'm assuming that's not an issue. I can replace it with analogous division before multiplication code if desired as it's possible to prove one of the terms is divisible by 3, and either
p+1orp+2should be even and divisible by 2.I left
TriangleNumbersas a utility, although it may not be needed anymore as it is not referenced externally and was only used for this calculation.