Repository navigation
fix(deps): require cmdstanpy 1.3.2 so Windows source builds stop fetching a retired Rtools URL - #2784
iruzen-dono wants to merge 2 commits into
Conversation
…hing a retired Rtools URL `cmdstanpy` 1.3.0 downloads the RTools 4.0 installer from `cran.r-project.org/bin/windows/Rtools/rtools40-x86_64.exe`, which CRAN retired (HTTP 404). 1.3.2 uses `cran-archive.r-project.org`, which still serves it. The metadata asked for `>=1.0.4`, so a stale pip cache on the runner resolved 1.3.0 and every Windows source/editable build died while compiling the Stan model, before a single test ran. The floor moves to `>=1.3.2` in both places the file declares it: the build system's `requires` (used by the editable install that failed) and the project dependencies. 1.3.2 supports Python >=3.9, so the `>=3.10` this project already requires is unaffected. The Actions-cache side of the report is a maintainer call; this change only makes the metadata stop permitting the broken release.
|
Hi @iruzen-dono! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Ready for review. The dependency floor is the whole change: Why it is the right floor: 1.3.0 fetches RTools 4.0 from The |
Fixes #2777
What
cmdstanpyfloor raised from>=1.0.4to>=1.3.2inpython/pyproject.toml, in both places the file declares it:[build-system] requires— the editable install that fails is a build-system requirement, so the floor has to be there or the build can still resolve 1.3.0.[project] dependencies— a source install from metadata must not permit the broken release either.Why 1.3.2
cran.r-project.org/bin/windows/Rtools/rtools40-x86_64.execran-archive.r-project.org/bin/windows/Rtools/rtools40-x86_64.exe1.3.2 is the latest on PyPI and requires
python >=3.9, so this project's>=3.10is unaffected.Verification
The dependency graph resolves to the intended release, and the rest of the metadata is untouched:
python -c "import tomllib; tomllib.load(open('python/pyproject.toml','rb'))"parses, and both declarations carry the new floor.I could not run the Windows build itself here (it compiles the Stan model), so the CI job is the real check:
build-and-test-python (3.12, windows-latest)should now fetch RTools fromcran-archiveinstead of dying.Not in this PR
The reporter's other suspicion — the runner's pip cache being why 1.3.0 won the resolution — is left alone. Clearing the Actions cache is a maintainer action, and pinning in CI instead would leave the package metadata wrong for everyone installing from a checkout.
AI disclosure
Prepared with an AI agent (Hermes), reviewed before submission.