Repository navigation
SCIP indexer - #5504
Open
yangdanny97 wants to merge 25 commits into
Open
SCIP indexer#5504yangdanny97 wants to merge 25 commits into
yangdanny97 wants to merge 25 commits into
Conversation
adds reproductions snapshots for a few minor bugs
[scip][13/n] More improvements
|
✅ This PR meets all requirements from our pull request checklist. Optional recommendations:
Note: this comment updates automatically after changes to the PR. Updates may take up to half an hour. |
SCIP indexes name the tool that produced them in metadata.tool_info.name, and indexers conventionally use a scip- prefix (scip-python, scip-java, scip-typescript). Writing scip-pyrefly makes the producer clear to SCIP consumers alongside other indexers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017Bffbuhqr9Q4j6RVYDgryu
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017Bffbuhqr9Q4j6RVYDgryu
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D129353935. (Because this pull request was imported automatically, there will not be any future comments.) |
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a SCIP indexer to Pyrefly, modeled after our existing setups for glean & code coverage. It is intended to be a replacement for Sourcegraph's scip-python, tho outputs are not 100% identical.
Test Plan
Snapshot tests, manual runs comparing with scip-python for repos like pytorch