Fixes for macOS - #34
Open
kbaker wants to merge 1484 commits into
Open
Conversation
githubuser0xFFFF
force-pushed
the
master
branch
7 times, most recently
from
February 10, 2023 13:55
3ee0c84 to
54c2bd0
Compare
githubuser0xFFFF
force-pushed
the
master
branch
2 times, most recently
from
February 27, 2023 07:04
cbb46f9 to
6362d14
Compare
…kAreaHasAutoHideButton flag
… overlays - no auto hide overlay for non pinnable dock widgets
… sidebar position
- the scroll wheel operation only worked between the tabbed buttons and not when the mouse was on the auto hide tab button. since the auto hide side bar already had event filters applied to the auto hide tab buttons, a filtered event of the mouse wheel is redirected to be handled by the auto hide side bar class itself. - the auto hide side bar class now handles the wheel event to correctly handle the direction the auto scroll should take. previously, when the scroll operation was performed on a vertical auto hide side bar, the scroll operation with no keyboard modifiers would scroll vertically as expected. when a scroll operation was performed on a horizontal auto hide side bar, the scroll operation would still move the viewport vertically. this change now detects the orientation of the auto hide side bar to correctly apply the mouse wheel operation. - the alt key will no longer have any effect. when the alt key was held during the scroll operation, the opposite scroll operation was performed. if alt is detected, the x and y angle deltas are just swapped to perform the correct scroll operation. - validated the following combinations: * Windows 11 Qt6 x86_64 * Windows 11 Qt5 x86_64 * Kubuntu 25.10 Qt6 Wayland x86_64
- adding a new alias that drops the -qt# but keeps the base library name
- the commit simplifies ads version management by making the main cmake project of ads the single source of truth for the library version; it removes the dependency of git or the ADS_VERSION variable during the cmake configuration process. this makes builds more reliable for source archives, package maintainers and managers, shallow clones, etc. this commit will auto-generate ads_version.h with defined variables that represent the current version associated to the qtads cmake project command. by providing ads_version.h, downstream projects have the ability to perform compile-time feature checks. ads_version.h mimics qt's version information macros. - Versioning.cmake was updated to remove the automatic git tag extraction when including said cmake file. in its place, a new function to be called by the qt ads library cmake file to auto-generate the ads_version.h file. this file contains the current version information as defined by the main cmake file's project command. the ads_version.h file is placed next to ads_globals.h and uese ads_version.h.in to generate from. - ads_version.h mimics qt's version and version check system. - the .gitignore was updated to make sure the auto-generated ads_version.h is ignored by git. - the main cmake file for ads no longer extracts the version information from ADS_VERSION if defined or git tags. the QtADS project call now requires the human readable VERSION argument to be supplied. the variables that were created are no longer needed. PROJECT_VERSION and the PROJECT_* components should all be replaced with QtADS_VERSION or QtADS_VERSION_* component. the VERSION_SHORT should just be replaced with QtADS_VERSION; VERSION_SONAME should just be replaced with QtADS_VERSION_MAJOR. - GetGitRevisionDescription cmake module files were removed as they are no longer needed in describing the current version of ads. - validated * Windows 11 - Visual Studio 2022 - CMake 4.3.3 - x86_64 * Kubuntu 25.10 - GCC 15.2.0 - CMake 3.31.6 - x86_64
…tion666/Qt-Advanced-Docking-System into Deception666-auto-hide-scroll-wheel-fix
- this change groups the different projects to folders in supported generators that correspond to an ide.
This adds support for docking single floating widgets on certain window managers (such as KDE, openbox, fly-wm) when CDockManager::AlwaysShowTabs is enabled.
The tab may be destroyed with the layout before the queued ensureWidgetVisible runs; guard it with QPointer and skip if gone.
Maintaining two independent build system is not possible and there is also no need
githubuser0xFFFF
force-pushed
the
master
branch
2 times, most recently
from
August 20, 2026 07:03
9834b3d to
9bd90ac
Compare
githubuser0xFFFF
force-pushed
the
master
branch
from
August 20, 2026 07:11
9bd90ac to
37bb442
Compare
githubuser0xFFFF
force-pushed
the
master
branch
from
August 20, 2026 09:01
6a77356 to
a51bca9
Compare
added 7 commits
August 20, 2026 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where dragging a floating dock container over the main window would make the floating dock container spontaneously go behind the main window.
Fixed an issue where dragging a floating dock container or a floating drag preview would attempt to dock with other floating dock containers that were partially or fully obscured by the main window.
Fixed some clazy warnings.
Fixed some comments on the close of private structures.