Repository navigation
Recognize abbreviations containing ampersands - #407
Open
Sinkleberg wants to merge 1 commit into
Open
Sinkleberg wants to merge 1 commit into
Sinkleberg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown Extra escapes ampersands before matching abbreviations, but stores abbreviation keys in their original form. As a result, a definition such as
*[AB&D]: Automated Build & Distributionnever matches the textAB&D.Normalize abbreviation keys with the same escaping used for inline text, for both document definitions and predefined abbreviations. Add regressions for both sources and
no_entities, while retaining word boundaries, code spans and escaped output. Fixes #391.All six MarkdownExtra unit tests pass; the three new regressions fail on the original source. On Windows with PHP 8.5, the full suite passes 113/114 tests; its remaining Windows path-filter failure also occurs on the unchanged base. PHPStan test analysis passes; source analysis reports the same seven existing errors on base and patch with the resolved PHPStan version. Other PHP versions, operating systems and hosted CI were not run.