Skip to content

Simplify and deduplicate CCF Raft kernel verification - #8651

Merged
Amaury Chamayou (achamayou) merged 1 commit into
mainfrom
achamayou-stunning-happiness
Nov 3, 2026
Merged

Amaury Chamayou (achamayou) merged 1 commit into
mainfrom
achamayou-stunning-happiness

Conversation

@achamayou

@achamayou Amaury Chamayou (achamayou) commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Motivation

Simplify CCF-Raft verification by checking its library and replay executable together, rather than rewriting lakefile.toml and running a separate kernel check for each target.
This removes a redundant verification invocation over overlapping dependencies and aligns Raft with the other packages, without dropping verification coverage.

This is a simplification and deduplication, not a demonstrated wall-time speedup.
The historical main-based run took 44m52s for Check packages and 53m24s for the full models job; this PR's run took 52m30s and 65m34s respectively.
Cache restoration also differed: 4m33s historically versus 7m32s on this PR.
These separate runs are not a controlled A/B comparison and establish neither a speedup nor a regression attributable to this change.
See the historical Lean CI run for merged #8633 and this PR's Lean CI run.
Any elapsed-time saving remains unmeasured pending a controlled comparison.

This is a standalone follow-up to #8339, based on main and not stacked on that KV PR.

Implementation summary

Run lake check --inadvisably-no-sandbox once per package, using the existing CCF-Raft default targets CCFRaft and ccfraft-replay together.
Remove the Raft-specific temporary configuration rewrite and restoration logic.
Update CCF-Raft validation documentation to describe the combined check.
This does not address repeated dependency verification across different packages.

Safety and compatibility

The Lean CI run passed.
Both default targets remain checked.
The warning-as-error build, kernel verification, standard axiom allowlist, import-coverage and architecture checks, linting, and fixture validation are retained.
This CI-only change has no runtime or compatibility impact.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 2, 2026 21:07
@achamayou
Amaury Chamayou (achamayou) requested a review from a team as a code owner November 2, 2026 21:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the Lean CI simplification and accompanying documentation updates.

No open issues 🎉

What changed in this PR

This PR simplifies CCF’s Lean CI by checking both Raft default targets in one invocation, avoiding a repeated kernel and axiom check. The expected runtime improvement is not yet measured.

Changes:

  • Replace Raft-specific per-target checks with one lake check --inadvisably-no-sandbox call per package.
  • Update validation documentation to describe the combined check of CCFRaft and ccfraft-replay.

Custom instructions used

Applied the CCF repository guidance supplied in the review context; no additional instruction files were loaded.

File Description
lean/​ccf-raft/​replay/​README.md Describe library and executable roots being checked together.
lean/​ccf-raft/​README.md Document one kernel-check invocation covering both default targets.
.github/​workflows/​lean.yml Remove temporary target rewrites and the separate Raft check loop.

Review effort: Balanced

@achamayou Amaury Chamayou (achamayou) changed the title Run CCF Raft kernel check once Simplify and deduplicate CCF Raft kernel verification Nov 2, 2026
@achamayou
Amaury Chamayou (achamayou) merged commit 5fe1c5c into main Nov 3, 2026
15 checks passed
@achamayou
Amaury Chamayou (achamayou) deleted the achamayou-stunning-happiness branch November 3, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants