Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an initial, source-grounded architecture knowledge base for maintainer discussion. This is a working draft, not approved engineering policy or ready for merging.
To narrow your attention if you could:
Go over section 1 (high level architecture) and section 2 (component responsibilities)
Is the high-level architecture materially correct?
Please help flag significant errors or any inaccuracies
Focus on Section 7
If you can help identify 2-3 candidate review rules worth prioritizing
Is there any important unwritten knowledge or recurring review concern that is missing?
A brief example or any pointer would help.
I'd say Sections 3-6 and 8-10 can be left as supporting reference documentation and not mandatory to skim at this stage.