Repository navigation
[AMD] Require and test amd-quark 0.13 for QuarkQuantization - #2793
Open
Thiago Crepaldi (thiagocrepaldi) wants to merge 2 commits into
Open
Thiago Crepaldi (thiagocrepaldi) wants to merge 2 commits into
Thiago Crepaldi (thiagocrepaldi) wants to merge 2 commits into
Conversation
The AMD CI installed amd-quark==0.10 (test/requirements-test-amd.txt), three releases behind the API the QuarkQuantization pass has used since microsoft#2532 (amd-quark>=0.12), so the pass's torch path was never tested against the Quark it targets. Test against the current release, amd-quark 0.13, and make it the pass's minimum (olive_config.json extra, the runtime version gates and their tests, and the docs). Verified with amd-quark 0.13, onnxruntime 1.28, torch 2.13 and transformers 5.15 / 5.22: test/passes/quark_quantizer passes (10 tests), and the pass runs AWQ uint4_wo_128 with a Hugging Face export on a tiny Llama. Co-Authored-By: Claude <noreply@anthropic.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the amd-quark 0.13 dependency and test-coverage updates.
No open issues 🎉
What changed in this PR
Aligns QuarkQuantization dependencies and AMD test coverage with amd-quark 0.13, building on the API updates introduced in #2532.
Changes:
- Raises the minimum amd-quark version to 0.13 for both ONNX and PyTorch paths.
- Pins AMD test dependencies to 0.13 and updates version-gate tests to reject 0.12.
- Documents the new minimum version.
| File | Description |
|---|---|
test/requirements-test-amd.txt |
Pins amd-quark to 0.13 for AMD testing. |
test/passes/quark_quantizer/test_quark_onnx_quantization.py |
Updates both version-gate tests and expected errors. |
olive/passes/quark_quantizer/quark_quantization.py |
Requires amd-quark ≥0.13.0 in both runtime paths. |
olive/olive_config.json |
Updates the pass dependency to amd-quark ≥0.13.0. |
docs/source/features/quantization.md |
Documents the amd-quark 0.13 requirement. |
Review effort: Balanced
Author
Baiju Meswani (baijumeswani)
approved these changes
Nov 7, 2026
Sunghoon Choi (hanbitmyths)
approved these changes
Nov 7, 2026
Sunghoon Choi (hanbitmyths)
enabled auto-merge (squash)
November 7, 2026 05:37
|
/azp run Olive CI |
|
Commenter does not have sufficient privileges for PR 2793 in repo microsoft/Olive |
Author
|
Thanks for the approvals. The only failing check is |
kunal-vaishnavi
approved these changes
Nov 7, 2026
Contributor
|
/azp run Olive CI |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Author
Baiju Meswani (baijumeswani)
approved these changes
Nov 7, 2026
Contributor
|
/azp run Olive CI |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Describe your changes
QuarkQuantizationnow requires and is tested against amd-quark 0.13, the current Quark release.Why. The AMD CI installs
amd-quark==0.10(test/requirements-test-amd.txt), three releases behind the API the pass has used since #2532 (amd-quark>=0.12). So the pass's torch path wasn't tested against the Quark it targets.Impact on users. The released olive-ai 0.13.0 still uses the Quark 0.11 API, and with any amd-quark since 0.12 its torch path fails:
pip install olive-ai amd-quarkgives exactly that combination today. Main is fixed (#2532) but not released.This PR:
test/requirements-test-amd.txt:amd-quark==0.13.QuarkQuantizationrequiresamd-quark>=0.13.0, in four places:olive_config.jsonextra;docs/source/features/quantization.md.Verification. Tested with amd-quark 0.13, onnxruntime 1.28, torch 2.13 and transformers 5.15 / 5.22:
pytest test/passes/quark_quantizerpasses (10 tests).uint4_wo_128with a Hugging Face export on a tiny Llama.Request. Could this go into a release soon? Every released olive-ai fails with the current amd-quark.
Checklist before requesting a review
lintrunner -a(not run; the change is version strings only)QuarkQuantizationrequires amd-quark >= 0.13.🤖 Generated with Claude Code