MAINT Simplify Foundry technique mapping - #2336
Open
Roman Lutz (romanlutz) wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 41c8a28e-3109-4b71-b97a-3d8ec8834136
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 41c8a28e-3109-4b71-b97a-3d8ec8834136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RedTeamAgent._get_attack_from_techniqueencoded the Foundry attack and converter catalog in a long conditional chain, making supported mappings and constructor exceptions difficult to audit. This replaces those branches with immutable, Foundry-local attack and converter specifications while retaining direct attack construction rather than adopting the mutable global registry.The refactor preserves all existing behavior: baseline and four attack mappings, all 21 converter mappings, converter order, fresh instances, Caesar/suffix/Tense/Jailbreak defaults, exact unsupported-converter errors, unknown-attack fallback, and PAIR/TAP scoring semantics. The mapping portion of
_get_attack_from_techniqueis reduced from 70 lines to 22.Tests and Documentation
Added exhaustive parameterized coverage for every attack and converter mapping, enum completeness, special constructor arguments, fresh Jailbreak templates, converter ordering, unsupported values, baseline fallback, and PAIR/TAP scorer behavior.
Validated with:
tests/unit/scenario/foundry/test_red_team_agent.py(56 passed)tests/partner_integration/azure_ai_evaluation/test_foundry_scenario_contract.py(7 passed)tychecksDocumentation is unchanged because the public Foundry API and behavior are unchanged. JupyText was not applicable.