Treat EFSBADCRC as disk corruption - #41368
Open
Feng Wang (chemwolf6922) wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves WSL service error handling during instance startup by treating mount failures that return errno 74 (EFSBADCRC) as disk corruption, aligning user-facing failures with the actual underlying filesystem state (as reported in #13616).
Changes:
- Extend the mount-disk failure mapping to classify errno 74 as
WSL_E_DISK_CORRUPTED. - Update the inline comment documenting which errno values indicate filesystem corruption during
LxInitCreateInstanceStepMountDisk.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Mount could fail with errno 74 (EFSBADCRC) when the filesystem is corrupted. For example, in #13616. It is directly presented to the user as E_FAIL and could cause confusions.
This PR adds it to the error codes treated as disk corruption.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed