Repository navigation
Conversation
…vigation Modified activations (Ctrl/Cmd+Click, Ctrl/Cmd+Enter) opened links via window.open without noopener, bypassing rel="noopener noreferrer". Fixes microsoft#36901 Signed-off-by: iyoriovo <iyorixy1@gmail.com>
Signed-off-by: iyoriovo <iyorixy1@gmail.com>
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36901
Description
<fluent-anchor-button>routes modified activations (Ctrl/Cmd+Click andCtrl/Cmd+Enter) through
window.open(this.href, '_blank')without anoopenerfeatures argument.window.opendoes not receive theimplicit-noopener protection that browsers apply to
target="_blank"anchor navigation, so the opened document gets access to
window.opener,even when the author explicitly sets
rel="noopener noreferrer".Plain clicks go through the component's internal proxy anchor, which does
forward
rel="noopener noreferrer", so the behavior is inconsistent withinthe same component (repro in #36901).
Change
Pass
noopener,noreferrerin the features argument ofwindow.opensomodified activations honor the same protection as plain clicks and native
anchors.
Verified against published
@fluentui/web-components@3.1.3: Ctrl+Click onfluent-anchor-buttonyieldswindow.openerin the opened tab, while anative
<a target="_blank" rel="noopener noreferrer">control yieldsnull.