Repository navigation
Restrict basic C# sample package source - #576
Open
Akshay Sonawane (apsonawane) wants to merge 3 commits into
Open
Akshay Sonawane (apsonawane) wants to merge 3 commits into
Akshay Sonawane (apsonawane) wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the NuGet package source configuration for the basic C# plugin execution provider sample to ensure restores use only the intended local package feed.
Changes:
- Clears any inherited/default NuGet package sources in
nuget.config. - Ensures the only configured source is the explicitly defined
local_feedpath.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
The added nuget.org feed lacks source mapping, allowing a missing local execution-provider package to resolve to a matching public package whose native library the sample then loads.
2 open issues
1 resolved since last review
Review effort: Max
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This pull request restricts the C# plugin execution provider sample to an explicit two-source NuGet allowlist.
Contoso.ML.OnnxRuntime.EP.Basicexactly to the generatedlocal_feed, so a missing local package cannot fall back to a public package with the same ID.Microsoft.ML.OnnxRuntimeand its public dependencies.This keeps the locally built execution-provider package local while preserving clean restores of the sample's approved public dependencies.