fix(sync): clear __pw_stack__ on task completion to prevent memory le… - #3158
Closed
atiqur-rahman-pro wants to merge 1 commit into
Closed
fix(sync): clear __pw_stack__ on task completion to prevent memory le…#3158atiqur-rahman-pro wants to merge 1 commit into
atiqur-rahman-pro wants to merge 1 commit into
Conversation
Member
|
Closing per #3157 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In
playwright/_impl/_sync_base.py,inspect.stack(0)is attached totask.__pw_stack__. Because liveFrameInfoobjects pin all caller local variables in memory, retaining the task causes a memory leak.This PR updates
task.add_done_callbackto deletetask.__pw_stack__upon task completion, ensuring frame objects and local variables are garbage collected immediately.Fixes #3157